Terminator Salvation is okay. It's acting is serviceable, with Christian Bale turning in a decent performance. The special effects are cool, and the CGI is expectedly improved from the previous Terminator films (which were already excellent).
Where the movie falters most is in its storytelling. The plot fails to put together any sort of momentum or narrative flow, and the film suffers as a result. When taken separately, the main storylines are more impactful; however, the film does a poor job of balancing these moving parts, resulting in an ending that tries to be poignant but feels unearned.
Terminator Salvation has a lot of ambition that is, unfortunately, never fully realized. It's worth watching, but you will be left wondering what could have been.